From 66091f934a2d064ae55095cdc5ae008b43ea60fe Mon Sep 17 00:00:00 2001
From: Lars Hjemli
Date: Tue, 16 Jan 2007 18:41:01 +0100
Subject: Handle empty/malformed commit messages
An empty commit message would trigger a segfault in the current
cgit_parse_commit().
Also, make sure that all char-pointers are properly initialized.
---
parsing.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/parsing.c b/parsing.c
index 4173dd4..4412dee 100644
--- a/parsing.c
+++ b/parsing.c
@@ -145,6 +145,12 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
ret = xmalloc(sizeof(*ret));
ret->commit = commit;
+ ret->author = NULL;
+ ret->author_email = NULL;
+ ret->committer = NULL;
+ ret->committer_email = NULL;
+ ret->subject = NULL;
+ ret->msg = NULL;
if (strncmp(p, "tree ", 5))
die("Bad commit: %s", sha1_to_hex(commit->object.sha1));
@@ -180,12 +186,13 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
p = strchr(p, '\n') + 1;
t = strchr(p, '\n');
- ret->subject = substr(p, t);
- p = t + 1;
-
- while (*p == '\n')
- p = strchr(p, '\n') + 1;
- ret->msg = p;
+ if (t && *t) {
+ ret->subject = substr(p, t);
+ p = t + 1;
+ while (*p == '\n')
+ p = strchr(p, '\n') + 1;
+ ret->msg = p;
+ }
return ret;
}
--
cgit 1.4.1-21-gabe81