about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorEric Wong2012-01-04 09:01:51 +0000
committerLars Hjemli2012-03-18 09:26:31 +0000
commit21418ec42a9a2de4c2c22eca7a1183b311914eca (patch)
tree76466eb627a017c57686530f0458699cb60d5684
parentuse correct type for sizeof (diff)
downloadcgit-21418ec42a9a2de4c2c22eca7a1183b311914eca.tar.gz
cgit-21418ec42a9a2de4c2c22eca7a1183b311914eca.zip
segfault fix on some bogus requests
ctx.qry.head can be NULL in some cases due to bad requests
by weird bots.  I managed to reproduce with:

   PATH_INFO=/repo.git/shop.php QUERY_STRING=id=

Signed-off-by: Eric Wong <normalperson@yhbt.net>
-rw-r--r--ui-shared.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ui-shared.c b/ui-shared.c index 3e9282f..d7d75bf 100644 --- a/ui-shared.c +++ b/ui-shared.c
@@ -294,7 +294,7 @@ void cgit_log_link(const char *name, const char *title, const char *class,
294 char *delim; 294 char *delim;
295 295
296 delim = repolink(title, class, "log", head, path); 296 delim = repolink(title, class, "log", head, path);
297 if (rev && strcmp(rev, ctx.qry.head)) { 297 if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
298 html(delim); 298 html(delim);
299 html("id="); 299 html("id=");
300 html_url_arg(rev); 300 html_url_arg(rev);
@@ -338,7 +338,7 @@ void cgit_commit_link(char *name, const char *title, const char *class,
338 char *delim; 338 char *delim;
339 339
340 delim = repolink(title, class, "commit", head, path); 340 delim = repolink(title, class, "commit", head, path);
341 if (rev && strcmp(rev, ctx.qry.head)) { 341 if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
342 html(delim); 342 html(delim);
343 html("id="); 343 html("id=");
344 html_url_arg(rev); 344 html_url_arg(rev);