about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJohn Keeping2022-02-13 15:29:06 +0000
committerJune McEnroe2022-02-18 00:01:45 +0000
commit28c0cb6f72a8f2d0f5afcd854261aebdf832012b (patch)
tree52c45caa7d6f5afed51491f5d2a5efa4aad42284
parentFix fmt() off-by-one error (diff)
downloadcgit-28c0cb6f72a8f2d0f5afcd854261aebdf832012b.tar.gz
cgit-28c0cb6f72a8f2d0f5afcd854261aebdf832012b.zip
Add a link to the parent commit in blame
When walking through the history, it is useful to quickly see the same
file at the previous revision, so add a link to do this.

It would be nice to link to the correct line with an additional
fragment, but this requires significantly more work so it can be done as
an enhancement later.  (ent->s_lno is mostly the right thing, but it is
the line number in the post-image of the target commit whereas the link
is to the parent of that commit, i.e. the pre-image of the target.)

Suggested-by: Alejandro Colomar <alx.manpages@gmail.com>
Signed-off-by: John Keeping <john@keeping.me.uk>
-rw-r--r--ui-blame.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/ui-blame.c b/ui-blame.c index 4adec2b..aedce8d 100644 --- a/ui-blame.c +++ b/ui-blame.c
@@ -54,6 +54,15 @@ static void emit_blame_entry_hash(struct blame_entry *ent)
54 html("</span>"); 54 html("</span>");
55 free(detail); 55 free(detail);
56 56
57 if (!parse_commit(suspect->commit) && suspect->commit->parents) {
58 struct commit *parent = suspect->commit->parents->item;
59
60 html(" ");
61 cgit_blame_link("^", "Blame the previous revision", NULL,
62 ctx.qry.head, oid_to_hex(&parent->object.oid),
63 suspect->path);
64 }
65
57 while (line++ < ent->num_lines) 66 while (line++ < ent->num_lines)
58 html("\n"); 67 html("\n");
59} 68}