about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLukas Fleischer2011-05-24 20:38:40 +0200
committerLars Hjemli2011-05-30 23:55:19 +0200
commit69382320d96232ee8c73e664797da61e733c2427 (patch)
tree7f1d53505859cc6e15b261249a22d1604b3cd037
parentfix virtual-root if script-name is "" (diff)
downloadcgit-69382320d96232ee8c73e664797da61e733c2427.tar.gz
cgit-69382320d96232ee8c73e664797da61e733c2427.zip
Properly escape ampersands inside HTML attributes
Ampersands ("&") appearing inside HTML attributes need to be translated
to "&". Otherwise, invalid XHTML will be generated at various
places, such as at tree views containing links to submodules.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--html.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/html.c b/html.c index a0f6db4..24a03a5 100644 --- a/html.c +++ b/html.c
@@ -138,7 +138,7 @@ void html_attr(const char *txt)
138 const char *t = txt; 138 const char *t = txt;
139 while(t && *t){ 139 while(t && *t){
140 int c = *t; 140 int c = *t;
141 if (c=='<' || c=='>' || c=='\'' || c=='\"') { 141 if (c=='<' || c=='>' || c=='\'' || c=='\"' || c=='&') {
142 html_raw(txt, t - txt); 142 html_raw(txt, t - txt);
143 if (c=='>') 143 if (c=='>')
144 html("&gt;"); 144 html("&gt;");
@@ -148,6 +148,8 @@ void html_attr(const char *txt)
148 html("&#x27;"); 148 html("&#x27;");
149 else if (c=='"') 149 else if (c=='"')
150 html("&quot;"); 150 html("&quot;");
151 else if (c=='&')
152 html("&amp;");
151 txt = t+1; 153 txt = t+1;
152 } 154 }
153 t++; 155 t++;