diff options
author | Dan McGee | 2011-01-12 12:06:08 -0600 |
---|---|---|
committer | Lars Hjemli | 2011-02-19 15:00:18 +0100 |
commit | aae067197f3fff253800359649d1f10014b23ecd (patch) | |
tree | 15ec47eafc2f1cd39f0557e61c4138f4b40537b7 | |
parent | Allow disabling of HTTP clone URLs (diff) | |
download | cgit-aae067197f3fff253800359649d1f10014b23ecd.tar.gz cgit-aae067197f3fff253800359649d1f10014b23ecd.zip |
Return 404 on command not found
We were returning 200 before. Even 404 is questionable in all cases, but 200 was totally wrong. Also match the case of all of the "Not found" status messsages. Signed-off-by: Dan McGee <dpmcgee@gmail.com> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | cgit.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/cgit.c b/cgit.c index 65fad7a..e0c2d9f 100644 --- a/cgit.c +++ b/cgit.c | |||
@@ -429,7 +429,7 @@ static int prepare_repo_cmd(struct cgit_context *ctx) | |||
429 | tmp = xstrdup(ctx->qry.head); | 429 | tmp = xstrdup(ctx->qry.head); |
430 | ctx->qry.head = ctx->repo->defbranch; | 430 | ctx->qry.head = ctx->repo->defbranch; |
431 | ctx->page.status = 404; | 431 | ctx->page.status = 404; |
432 | ctx->page.statusmsg = "not found"; | 432 | ctx->page.statusmsg = "Not found"; |
433 | cgit_print_http_headers(ctx); | 433 | cgit_print_http_headers(ctx); |
434 | cgit_print_docstart(ctx); | 434 | cgit_print_docstart(ctx); |
435 | cgit_print_pageheader(ctx); | 435 | cgit_print_pageheader(ctx); |
@@ -448,6 +448,8 @@ static void process_request(void *cbdata) | |||
448 | cmd = cgit_get_cmd(ctx); | 448 | cmd = cgit_get_cmd(ctx); |
449 | if (!cmd) { | 449 | if (!cmd) { |
450 | ctx->page.title = "cgit error"; | 450 | ctx->page.title = "cgit error"; |
451 | ctx->page.status = 404; | ||
452 | ctx->page.statusmsg = "Not found"; | ||
451 | cgit_print_http_headers(ctx); | 453 | cgit_print_http_headers(ctx); |
452 | cgit_print_docstart(ctx); | 454 | cgit_print_docstart(ctx); |
453 | cgit_print_pageheader(ctx); | 455 | cgit_print_pageheader(ctx); |