about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorChristian Hesse2015-10-10 16:56:27 +0200
committerJason A. Donenfeld2015-10-10 21:40:26 +0200
commited5dccbeaab5c8b30e1c2fe8890fa098537a2621 (patch)
treee3a672c17f5589a417bf9318f6b31a598c5aa8f8
parentui-atom: fix resource leak: free before return (diff)
downloadcgit-ed5dccbeaab5c8b30e1c2fe8890fa098537a2621.tar.gz
cgit-ed5dccbeaab5c8b30e1c2fe8890fa098537a2621.zip
ui-atom: fix resource leak: free allocation from cgit_pageurl
Coverity-id: 13945
Signed-off-by: Christian Hesse <mail@eworm.de>
-rw-r--r--ui-atom.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/ui-atom.c b/ui-atom.c index fab4b0f..e186299 100644 --- a/ui-atom.c +++ b/ui-atom.c
@@ -53,14 +53,17 @@ static void add_entry(struct commit *commit, const char *host)
53 cgit_print_date(info->author_date, FMT_ATOMDATE, 0); 53 cgit_print_date(info->author_date, FMT_ATOMDATE, 0);
54 html("</published>\n"); 54 html("</published>\n");
55 if (host) { 55 if (host) {
56 char *pageurl;
56 html("<link rel='alternate' type='text/html' href='"); 57 html("<link rel='alternate' type='text/html' href='");
57 html(cgit_httpscheme()); 58 html(cgit_httpscheme());
58 html_attr(host); 59 html_attr(host);
59 html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL)); 60 pageurl = cgit_pageurl(ctx.repo->url, "commit", NULL);
61 html_attr(pageurl);
60 if (ctx.cfg.virtual_root) 62 if (ctx.cfg.virtual_root)
61 delim = '?'; 63 delim = '?';
62 htmlf("%cid=%s", delim, hex); 64 htmlf("%cid=%s", delim, hex);
63 html("'/>\n"); 65 html("'/>\n");
66 free(pageurl);
64 } 67 }
65 htmlf("<id>%s</id>\n", hex); 68 htmlf("<id>%s</id>\n", hex);
66 html("<content type='text'>\n"); 69 html("<content type='text'>\n");