about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLars Hjemli2007-09-20 00:00:06 +0200
committerLars Hjemli2007-09-20 00:05:59 +0200
commitff7a39488adbee9cb57bf4549efd60e6b7d4fc1a (patch)
tree20dd27ce96d8b7b84e0da84b0cca94a7e17ea11c
parentui-tree: specify parameter position for all htmlf formats (diff)
downloadcgit-ff7a39488adbee9cb57bf4549efd60e6b7d4fc1a.tar.gz
cgit-ff7a39488adbee9cb57bf4549efd60e6b7d4fc1a.zip
ui-tree: show last line of blob
The last line in a blob was never printed by ui-tree::print_object(), which
was particularly annoying when the blob missed a final newline. This fixes
the issue.

Noticed-by: <mkraai@beckman.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--ui-tree.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/ui-tree.c b/ui-tree.c index ef44d61..15d1f5a 100644 --- a/ui-tree.c +++ b/ui-tree.c
@@ -17,6 +17,7 @@ static void print_object(const unsigned char *sha1, char *path)
17 enum object_type type; 17 enum object_type type;
18 unsigned char *buf; 18 unsigned char *buf;
19 unsigned long size, lineno, start, idx; 19 unsigned long size, lineno, start, idx;
20 const char *linefmt = "<tr><td class='no'><a name='%1$d'>%1$d</a></td><td class='txt'>";
20 21
21 type = sha1_object_info(sha1, &size); 22 type = sha1_object_info(sha1, &size);
22 if (type == OBJ_BAD) { 23 if (type == OBJ_BAD) {
@@ -43,14 +44,16 @@ static void print_object(const unsigned char *sha1, char *path)
43 while(idx < size) { 44 while(idx < size) {
44 if (buf[idx] == '\n') { 45 if (buf[idx] == '\n') {
45 buf[idx] = '\0'; 46 buf[idx] = '\0';
46 htmlf("<tr><td class='no'><a name='%1$d'>%1$d</a></td><td class='txt'>", 47 htmlf(linefmt, ++lineno);
47 ++lineno);
48 html_txt(buf + start); 48 html_txt(buf + start);
49 html("</td></tr>\n"); 49 html("</td></tr>\n");
50 start = idx + 1; 50 start = idx + 1;
51 } 51 }
52 idx++; 52 idx++;
53 } 53 }
54 htmlf(linefmt, ++lineno);
55 html_txt(buf + start);
56 html("</td></tr>\n");
54 html("</table>\n"); 57 html("</table>\n");
55} 58}
56 59