about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLukas Fleischer2014-01-10 12:44:36 +0100
committerJason A. Donenfeld2014-01-10 17:03:18 +0100
commit2abce4300b90fa80845193c14d4b6849720007b1 (patch)
tree8c094396b63bd127277ab6d229c2f49150cc6710
parentReplace most uses of strncmp() with prefixcmp() (diff)
downloadcgit-2abce4300b90fa80845193c14d4b6849720007b1.tar.gz
cgit-2abce4300b90fa80845193c14d4b6849720007b1.zip
Disallow use of undocumented snapshot delimiters
Since the introduction of selective snapshot format configuration in
dc3c9b5 (allow selective enabling of snapshots, 2007-07-21), we allowed
seven different delimiters for snapshot formats, while the documentation
has always been clear about spaces being the only valid delimiter:

    The value is a space-separated list of zero or more of the values
    "tar", "tar.gz", "tar.bz2", "tar.xz" and "zip".

Supporting the undocumented delimiters makes the code unnecessarily
complex. Remove them.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
-rw-r--r--shared.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/shared.c b/shared.c index c5c4b00..1f6310a 100644 --- a/shared.c +++ b/shared.c
@@ -405,7 +405,7 @@ void cgit_diff_commit(struct commit *commit, filepair_fn fn, const char *prefix)
405int cgit_parse_snapshots_mask(const char *str) 405int cgit_parse_snapshots_mask(const char *str)
406{ 406{
407 const struct cgit_snapshot_format *f; 407 const struct cgit_snapshot_format *f;
408 static const char *delim = " \t,:/|;"; 408 static const char *delim = " ";
409 int tl, sl, rv = 0; 409 int tl, sl, rv = 0;
410 410
411 /* favor legacy setting */ 411 /* favor legacy setting */