about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLars Hjemli2009-08-17 09:05:13 +0200
committerLars Hjemli2009-08-17 09:26:17 +0200
commit435a1da8d1c43bff2f2ccd5649ea8510eec0b2af (patch)
treec07a9d096c99a70e78b017b5edccb1eaaffd0795
parentui-tag.c: do not segfault when id is missing from query-string (diff)
downloadcgit-435a1da8d1c43bff2f2ccd5649ea8510eec0b2af.tar.gz
cgit-435a1da8d1c43bff2f2ccd5649ea8510eec0b2af.zip
cgit.c: do not segfault on unexpected query-string format
The querystring_cb() function will be invoked with a NULL value when
the querystring contains a name not followed by a '='. Such a value
used to cause a segfault, which this patch fixes.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--cgit.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/cgit.c b/cgit.c index 64d95f9..5301840 100644 --- a/cgit.c +++ b/cgit.c
@@ -132,6 +132,9 @@ void config_cb(const char *name, const char *value)
132 132
133static void querystring_cb(const char *name, const char *value) 133static void querystring_cb(const char *name, const char *value)
134{ 134{
135 if (!value)
136 value = "";
137
135 if (!strcmp(name,"r")) { 138 if (!strcmp(name,"r")) {
136 ctx.qry.repo = xstrdup(value); 139 ctx.qry.repo = xstrdup(value);
137 ctx.repo = cgit_get_repoinfo(value); 140 ctx.repo = cgit_get_repoinfo(value);