diff options
author | Lars Hjemli | 2008-12-01 21:56:07 +0100 |
---|---|---|
committer | Lars Hjemli | 2008-12-01 22:01:10 +0100 |
commit | 6596268576a4f5fe2f5c8a3238856b0fb205ff76 (patch) | |
tree | 9cd8a7b68a6aeea9aa44e7b25dacc8f9cdc918f1 | |
parent | ui-shared: exploit snapshot dwimmery in cgit_print_snapshot_links (diff) | |
download | cgit-6596268576a4f5fe2f5c8a3238856b0fb205ff76.tar.gz cgit-6596268576a4f5fe2f5c8a3238856b0fb205ff76.zip |
ui-refs.c: show download links for all tags referring to commit objects
The snapshot function has only been linked to from the commit page while users often would want to download a certain release. With this patch, direct download links will now be printed for each tagged release on the repo summary page. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-refs.c | 37 |
1 files changed, 34 insertions, 3 deletions
diff --git a/ui-refs.c b/ui-refs.c index 32e0429..0805fc8 100644 --- a/ui-refs.c +++ b/ui-refs.c | |||
@@ -78,12 +78,37 @@ static int print_branch(struct refinfo *ref) | |||
78 | static void print_tag_header() | 78 | static void print_tag_header() |
79 | { | 79 | { |
80 | html("<tr class='nohover'><th class='left'>Tag</th>" | 80 | html("<tr class='nohover'><th class='left'>Tag</th>" |
81 | "<th class='left'>Reference</th>" | 81 | "<th class='left'>Download</th>" |
82 | "<th class='left'>Author</th>" | 82 | "<th class='left'>Author</th>" |
83 | "<th class='left' colspan='2'>Age</th></tr>\n"); | 83 | "<th class='left' colspan='2'>Age</th></tr>\n"); |
84 | header = 1; | 84 | header = 1; |
85 | } | 85 | } |
86 | 86 | ||
87 | static void print_tag_downloads(const struct cgit_repo *repo, const char *ref) | ||
88 | { | ||
89 | const struct cgit_snapshot_format* f; | ||
90 | char *filename; | ||
91 | const char *basename; | ||
92 | |||
93 | if (!ref || strlen(ref) < 2) | ||
94 | return; | ||
95 | |||
96 | basename = cgit_repobasename(repo->url); | ||
97 | if (prefixcmp(ref, basename) != 0) { | ||
98 | if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1])) | ||
99 | ref++; | ||
100 | if (isdigit(ref[0])) | ||
101 | ref = xstrdup(fmt("%s-%s", basename, ref)); | ||
102 | } | ||
103 | |||
104 | for (f = cgit_snapshot_formats; f->suffix; f++) { | ||
105 | if (!(repo->snapshots & f->bit)) | ||
106 | continue; | ||
107 | filename = fmt("%s%s", ref, f->suffix); | ||
108 | cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename); | ||
109 | html(" "); | ||
110 | } | ||
111 | } | ||
87 | static int print_tag(struct refinfo *ref) | 112 | static int print_tag(struct refinfo *ref) |
88 | { | 113 | { |
89 | struct tag *tag; | 114 | struct tag *tag; |
@@ -98,7 +123,10 @@ static int print_tag(struct refinfo *ref) | |||
98 | html("<tr><td>"); | 123 | html("<tr><td>"); |
99 | cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); | 124 | cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); |
100 | html("</td><td>"); | 125 | html("</td><td>"); |
101 | cgit_object_link(tag->tagged); | 126 | if (ctx.repo->snapshots && (tag->tagged->type == OBJ_COMMIT)) |
127 | print_tag_downloads(ctx.repo, name); | ||
128 | else | ||
129 | cgit_object_link(tag->tagged); | ||
102 | html("</td><td>"); | 130 | html("</td><td>"); |
103 | if (info->tagger) | 131 | if (info->tagger) |
104 | html(info->tagger); | 132 | html(info->tagger); |
@@ -112,7 +140,10 @@ static int print_tag(struct refinfo *ref) | |||
112 | html("<tr><td>"); | 140 | html("<tr><td>"); |
113 | html_txt(name); | 141 | html_txt(name); |
114 | html("</td><td>"); | 142 | html("</td><td>"); |
115 | cgit_object_link(ref->object); | 143 | if (ctx.repo->snapshots && (tag->tagged->type == OBJ_COMMIT)) |
144 | print_tag_downloads(ctx.repo, name); | ||
145 | else | ||
146 | cgit_object_link(ref->object); | ||
116 | html("</td></tr>\n"); | 147 | html("</td></tr>\n"); |
117 | } | 148 | } |
118 | return 0; | 149 | return 0; |