diff options
author | Lars Hjemli | 2009-01-29 22:21:15 +0100 |
---|---|---|
committer | Lars Hjemli | 2009-01-29 22:21:15 +0100 |
commit | 7efcef00b5aadf22f5be80ecd7b736398cf7f6b4 (patch) | |
tree | 6bfdb7c5499ba43eb9b302394adc7bfa7e517436 | |
parent | CGIT 0.8.1.1 (diff) | |
download | cgit-7efcef00b5aadf22f5be80ecd7b736398cf7f6b4.tar.gz cgit-7efcef00b5aadf22f5be80ecd7b736398cf7f6b4.zip |
html.c: use correct escaping in html attributes
First, an apostrophe is not a quote. Second, we also need to escape quotes. And finally, quotes are encoded as '"', not '"e;'. Sighned-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | html.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/html.c b/html.c index d7d9fd7..66ba65d 100644 --- a/html.c +++ b/html.c | |||
@@ -112,14 +112,16 @@ void html_attr(char *txt) | |||
112 | char *t = txt; | 112 | char *t = txt; |
113 | while(t && *t){ | 113 | while(t && *t){ |
114 | int c = *t; | 114 | int c = *t; |
115 | if (c=='<' || c=='>' || c=='\'') { | 115 | if (c=='<' || c=='>' || c=='\'' || c=='\"') { |
116 | write(htmlfd, txt, t - txt); | 116 | write(htmlfd, txt, t - txt); |
117 | if (c=='>') | 117 | if (c=='>') |
118 | html(">"); | 118 | html(">"); |
119 | else if (c=='<') | 119 | else if (c=='<') |
120 | html("<"); | 120 | html("<"); |
121 | else if (c=='\'') | 121 | else if (c=='\'') |
122 | html(""e;"); | 122 | html("'"); |
123 | else if (c=='"') | ||
124 | html("""); | ||
123 | txt = t+1; | 125 | txt = t+1; |
124 | } | 126 | } |
125 | t++; | 127 | t++; |