diff options
| author | Lukas Fleischer | 2015-02-09 07:25:00 +0100 |
|---|---|---|
| committer | Jason A. Donenfeld | 2015-02-09 11:51:14 +0100 |
| commit | b66b16ed026c6f57ad8ae892c821d835113e7fb2 (patch) | |
| tree | 604193d1a658df7e3ebec743f5210dae86c4f2e9 | |
| parent | git: update for v2.3.0 (diff) | |
| download | cgit-b66b16ed026c6f57ad8ae892c821d835113e7fb2.tar.gz cgit-b66b16ed026c6f57ad8ae892c821d835113e7fb2.zip | |
ui-clone.c: Fix path check
The starts_with() check was broken in two ways: For one thing, the parameters were passed in the wrong order, for another thing, starts_with() returns 1 if the string starts with the prefix (not 0). Note that this bug existed since commit 02a545e (Add support for cloning over http, 2008-08-06) but only pops in in corner cases. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| -rw-r--r-- | ui-clone.c | 4 |
1 files changed, 2 insertions, 2 deletions
| diff --git a/ui-clone.c b/ui-clone.c index 50569d6..1e6238d 100644 --- a/ui-clone.c +++ b/ui-clone.c | |||
| @@ -63,8 +63,8 @@ static void send_file(char *path) | |||
| 63 | } | 63 | } |
| 64 | ctx.page.mimetype = "application/octet-stream"; | 64 | ctx.page.mimetype = "application/octet-stream"; |
| 65 | ctx.page.filename = path; | 65 | ctx.page.filename = path; |
| 66 | if (!starts_with(ctx.repo->path, path)) | 66 | skip_prefix(path, ctx.repo->path, &ctx.page.filename); |
| 67 | ctx.page.filename += strlen(ctx.repo->path) + 1; | 67 | skip_prefix(ctx.page.filename, "/", &ctx.page.filename); |
| 68 | cgit_print_http_headers(); | 68 | cgit_print_http_headers(); |
| 69 | html_include(path); | 69 | html_include(path); |
| 70 | } | 70 | } |