about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLars Hjemli2007-10-27 13:50:18 +0200
committerLars Hjemli2007-10-27 13:55:12 +0200
commitc61360fea0357672d2ab84a2c5a41ae1569f5d8a (patch)
treec0d55917537b1cbc8237ee63e3a1252abbdded40
parentSkip unknown header fields when parsing tags and commits (diff)
downloadcgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.gz
cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.zip
cgit_parse_commit(): Add missing call to xstrdup()
It's rather silly to point into random memory-locations. Also, remove a
call to strdup() used on a literal char *.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--parsing.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/parsing.c b/parsing.c index ddbafd5..30e7648 100644 --- a/parsing.c +++ b/parsing.c
@@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
242 t = strchr(p, '\n'); 242 t = strchr(p, '\n');
243 if (t) { 243 if (t) {
244 if (*t == '\0') 244 if (*t == '\0')
245 ret->subject = strdup("** empty **"); 245 ret->subject = "** empty **";
246 else 246 else
247 ret->subject = substr(p, t); 247 ret->subject = substr(p, t);
248 p = t + 1; 248 p = t + 1;
249 249
250 while (*p == '\n') 250 while (*p == '\n')
251 p = strchr(p, '\n') + 1; 251 p = strchr(p, '\n') + 1;
252 ret->msg = p; 252 ret->msg = xstrdup(p);
253 } else 253 } else
254 ret->subject = substr(p, p+strlen(p)); 254 ret->subject = substr(p, p+strlen(p));
255 255