about summary refs log tree commit diff stats
path: root/cgit.c
diff options
context:
space:
mode:
authorLars Hjemli2008-05-18 23:59:11 +0200
committerLars Hjemli2008-05-18 23:59:11 +0200
commitaf2e75616d1bfb7dc79d299d10ae0bd39bef47bc (patch)
tree6330a6f9bc1b2b16434df055ee48129e2e3b827e /cgit.c
parentcache.c: use xread()/xwrite() from libgit (diff)
downloadcgit-af2e75616d1bfb7dc79d299d10ae0bd39bef47bc.tar.gz
cgit-af2e75616d1bfb7dc79d299d10ae0bd39bef47bc.zip
cache.c: do not ignore errors from print_slot()
If print_slot() fails, the client will be served an inferior response.
This patch makes sure that such an error will be returned to main(), which
in turn will try to inform about the error in the response itself.

The error is also printed to the cache_log, i.e. stderr, which will make
the error message appear in error_log (atleast when httpd==apache).

Noticed-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'cgit.c')
-rw-r--r--cgit.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/cgit.c b/cgit.c index 2036ceb..ac882c3 100644 --- a/cgit.c +++ b/cgit.c
@@ -380,7 +380,7 @@ int main(int argc, const char **argv)
380 err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root, 380 err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root,
381 ctx.qry.raw, ttl, process_request, &ctx); 381 ctx.qry.raw, ttl, process_request, &ctx);
382 if (err) 382 if (err)
383 cache_log("[cgit] error %d - %s\n", 383 cgit_print_error(fmt("Error processing page: %s (%d)",
384 err, strerror(err)); 384 strerror(err), err));
385 return err; 385 return err;
386} 386}