about summary refs log tree commit diff stats
path: root/ui-atom.c
diff options
context:
space:
mode:
authorJohn Keeping2022-02-13 15:34:50 +0000
committerJune McEnroe2022-02-18 00:16:05 +0000
commit400fd7abbc9cf104999afeb05a7a40b8d58814b2 (patch)
treecd22901af7bc9cdc634543b1f13da840ae21f146 /ui-atom.c
parentReset font size for blame oid (diff)
downloadcgit-400fd7abbc9cf104999afeb05a7a40b8d58814b2.tar.gz
cgit-400fd7abbc9cf104999afeb05a7a40b8d58814b2.zip
Use release_commit_memory()
Instead of calling two separate Git functions to free memory associated
with a commit object, use Git's wrapper which does this.  This also
counts as a potential future bug fix since release_commit_memory() also
resets the parsed state of the commit, meaning any attempt to use it in
the future will correctly fill out the fields again.

release_commit_memory() does not set parents to zero, so keep that for
additional safety in case CGit checks this without calling
parse_commit() again.

Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'ui-atom.c')
-rw-r--r--ui-atom.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/ui-atom.c b/ui-atom.c index 8329e01..0cf8441 100644 --- a/ui-atom.c +++ b/ui-atom.c
@@ -149,8 +149,7 @@ void cgit_print_atom(char *tip, const char *path, int max_count)
149 first = 0; 149 first = 0;
150 } 150 }
151 add_entry(commit, host); 151 add_entry(commit, host);
152 free_commit_buffer(the_repository->parsed_objects, commit); 152 release_commit_memory(the_repository->parsed_objects, commit);
153 free_commit_list(commit->parents);
154 commit->parents = NULL; 153 commit->parents = NULL;
155 } 154 }
156 html("</feed>\n"); 155 html("</feed>\n");