Use release_commit_memory()

Instead of calling two separate Git functions to free memory associated
with a commit object, use Git's wrapper which does this.  This also
counts as a potential future bug fix since release_commit_memory() also
resets the parsed state of the commit, meaning any attempt to use it in
the future will correctly fill out the fields again.

release_commit_memory() does not set parents to zero, so keep that for
additional safety in case CGit checks this without calling
parse_commit() again.

Signed-off-by: John Keeping <john@keeping.me.uk>

1 files changed, 2 insertions, 4 deletions

@@ -493,8 +493,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
         for (i = 0; i < ofs && (commit = get_revision(&rev)) != NULL; /* nop */) {
                 if (show_commit(commit, &rev))
                         i++;
-                free_commit_buffer(the_repository->parsed_objects, commit);
-                free_commit_list(commit->parents);
+                release_commit_memory(the_repository->parsed_objects, commit);
                 commit->parents = NULL;
         }
 
@@ -515,8 +514,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
                         i++;
                         print_commit(commit, &rev);
                 }
-                free_commit_buffer(the_repository->parsed_objects, commit);
-                free_commit_list(commit->parents);
+                release_commit_memory(the_repository->parsed_objects, commit);
                 commit->parents = NULL;
         }
         if (pager) {