Use release_commit_memory()

Instead of calling two separate Git functions to free memory associated
with a commit object, use Git's wrapper which does this.  This also
counts as a potential future bug fix since release_commit_memory() also
resets the parsed state of the commit, meaning any attempt to use it in
the future will correctly fill out the fields again.

release_commit_memory() does not set parents to zero, so keep that for
additional safety in case CGit checks this without calling
parse_commit() again.

Signed-off-by: John Keeping <john@keeping.me.uk>

1 files changed, 1 insertions, 2 deletions

@@ -241,8 +241,7 @@ static struct string_list collect_stats(const struct cgit_period *period)
         memset(&authors, 0, sizeof(authors));
         while ((commit = get_revision(&rev)) != NULL) {
                 add_commit(&authors, commit, period);
-                free_commit_buffer(the_repository->parsed_objects, commit);
-                free_commit_list(commit->parents);
+                release_commit_memory(the_repository->parsed_objects, commit);
                 commit->parents = NULL;
         }
         return authors;