diff options
| author | John Keeping | 2013-04-06 11:23:52 +0100 |
|---|---|---|
| committer | Jason A. Donenfeld | 2013-04-08 16:11:29 +0200 |
| commit | ed5bd30ebe6921dd22948a3f33a314283f043606 (patch) | |
| tree | 494f1ac8aae7c2147146fefc9aebcdb1bfa671c0 /ui-tag.c | |
| parent | shared.c: add strbuf_ensure_end (diff) | |
| download | cgit-ed5bd30ebe6921dd22948a3f33a314283f043606.tar.gz cgit-ed5bd30ebe6921dd22948a3f33a314283f043606.zip | |
Convert cgit_print_error to a variadic function
This removes many uses of "fmt" which uses a fixed size static pool of fixed size buffers. Instead of relying on these, we now pass around argument lists for as long as possible before using a strbuf to render content of an arbitrary size. Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'ui-tag.c')
| -rw-r--r-- | ui-tag.c | 6 |
1 files changed, 3 insertions, 3 deletions
| diff --git a/ui-tag.c b/ui-tag.c index 5a22696..397e15b 100644 --- a/ui-tag.c +++ b/ui-tag.c | |||
| @@ -50,18 +50,18 @@ void cgit_print_tag(char *revname) | |||
| 50 | revname = ctx.qry.head; | 50 | revname = ctx.qry.head; |
| 51 | 51 | ||
| 52 | if (get_sha1(fmt("refs/tags/%s", revname), sha1)) { | 52 | if (get_sha1(fmt("refs/tags/%s", revname), sha1)) { |
| 53 | cgit_print_error(fmt("Bad tag reference: %s", revname)); | 53 | cgit_print_error("Bad tag reference: %s", revname); |
| 54 | return; | 54 | return; |
| 55 | } | 55 | } |
| 56 | obj = parse_object(sha1); | 56 | obj = parse_object(sha1); |
| 57 | if (!obj) { | 57 | if (!obj) { |
| 58 | cgit_print_error(fmt("Bad object id: %s", sha1_to_hex(sha1))); | 58 | cgit_print_error("Bad object id: %s", sha1_to_hex(sha1)); |
| 59 | return; | 59 | return; |
| 60 | } | 60 | } |
| 61 | if (obj->type == OBJ_TAG) { | 61 | if (obj->type == OBJ_TAG) { |
| 62 | tag = lookup_tag(sha1); | 62 | tag = lookup_tag(sha1); |
| 63 | if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) { | 63 | if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) { |
| 64 | cgit_print_error(fmt("Bad tag object: %s", revname)); | 64 | cgit_print_error("Bad tag object: %s", revname); |
| 65 | return; | 65 | return; |
| 66 | } | 66 | } |
| 67 | html("<table class='commit-info'>\n"); | 67 | html("<table class='commit-info'>\n"); |